Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Aug 7, 2024

This PR is a part of #7987

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 9 commits August 6, 2024 14:48
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Aug 7, 2024
7 tasks
@ericspod
Copy link
Member

ericspod commented Aug 7, 2024

I had very minor suggestions but otherwise looks fine.

yiheng-wang-nv and others added 5 commits August 8, 2024 10:25
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review August 8, 2024 09:07
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
KumoLiu and others added 6 commits August 9, 2024 15:18
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 9, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 9, 2024

Hi @yiheng-wang-nv, please help take a look at the ci error.

[2024-08-09T10:27:16.069Z] ======================================================================
[2024-08-09T10:27:16.069Z] ERROR: test_cp_shape_0 (tests.test_vista3d_utils.TestGetLargestConnectedComponentMaskPoint)
[2024-08-09T10:27:16.069Z] ----------------------------------------------------------------------
[2024-08-09T10:27:16.069Z] Traceback (most recent call last):
[2024-08-09T10:27:16.069Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-09T10:27:16.069Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_utils.py", line 122, in test_cp_shape
[2024-08-09T10:27:16.069Z]     mask = get_largest_connected_component_mask_point(**input_data)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/transforms/utils.py", line 1240, in get_largest_connected_component_mask_point
[2024-08-09T10:27:16.069Z]     x, y, z = p.round().int().tolist()
[2024-08-09T10:27:16.069Z] RuntimeError: "round_cuda" not implemented for 'Long'
[2024-08-09T10:27:16.069Z] 
[2024-08-09T10:27:16.069Z] ======================================================================
[2024-08-09T10:27:16.069Z] ERROR: test_cp_shape_1 (tests.test_vista3d_utils.TestGetLargestConnectedComponentMaskPoint)
[2024-08-09T10:27:16.069Z] ----------------------------------------------------------------------
[2024-08-09T10:27:16.069Z] Traceback (most recent call last):
[2024-08-09T10:27:16.069Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-09T10:27:16.069Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_utils.py", line 122, in test_cp_shape
[2024-08-09T10:27:16.069Z]     mask = get_largest_connected_component_mask_point(**input_data)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/transforms/utils.py", line 1240, in get_largest_connected_component_mask_point
[2024-08-09T10:27:16.069Z]     x, y, z = p.round().int().tolist()
[2024-08-09T10:27:16.069Z] RuntimeError: "round_cuda" not implemented for 'Long'

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 9, 2024

/build

@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) August 9, 2024 14:26
@yiheng-wang-nv yiheng-wang-nv merged commit f848002 into Project-MONAI:dev Aug 9, 2024
@yiheng-wang-nv yiheng-wang-nv deleted the add-utils-for-vista3d branch August 9, 2024 14:33
@KumoLiu KumoLiu added this to the VISTA 3D [P0 v1.4] milestone Aug 19, 2024
rcremese pushed a commit to rcremese/MONAI that referenced this pull request Sep 2, 2024
This PR is a part of Project-MONAI#7987 

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants