Skip to content

Add checks for num_fold and fail early if wrong - #7634

Merged
KumoLiu merged 4 commits into
Project-MONAI:devfrom
mingxin-zheng:mingxinz/fix-7628-fold
Apr 12, 2024
Merged

KumoLiu merged 4 commits into
Project-MONAI:devfrom
mingxin-zheng:mingxinz/fix-7628-fold

Conversation

@mingxin-zheng

Copy link
Copy Markdown
Collaborator

Fixes #7628 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mingxin <mingxinz@nvidia.com>
@mingxin-zheng
mingxin-zheng requested review from KumoLiu and myron April 12, 2024 04:15
mingxin-zheng and others added 2 commits April 12, 2024 04:19
Signed-off-by: Mingxin <mingxinz@nvidia.com>

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@KumoLiu

KumoLiu commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

/build

@KumoLiu
KumoLiu merged commit 9e2904a into Project-MONAI:dev Apr 12, 2024
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this pull request Apr 17, 2024
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <mingxinz@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this pull request Apr 17, 2024
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <mingxinz@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this pull request Apr 17, 2024
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <mingxinz@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@mingxin-zheng
mingxin-zheng deleted the mingxinz/fix-7628-fold branch July 1, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting arbitrary num_fold in AutoRunner is permitted regardless the Auto3DSeg datalist doesn't support

2 participants