Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle_root for NNIGen #7586

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

mingxin-zheng
Copy link
Contributor

Fixes #7585 .

Description

Because the NNI test takes too much time, the previous behavior did not get caught with the dry-run mode of HPO Gen

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 27, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 27, 2024

Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
@mingxin-zheng
Copy link
Contributor Author

Thanks @KumoLiu . Just fixed this. It seems some buggy hehavior started from #6414 and the HPO tests were incorrectly modified.

python -m unittest tests.test_auto3dseg_hpo.TestHPO.test_get_history
...
.
----------------------------------------------------------------------
Ran 1 test in 55.764s

OK

@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 27, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) March 27, 2024 09:18
@KumoLiu KumoLiu merged commit 7c0b10e into Project-MONAI:dev Mar 27, 2024
28 checks passed
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
Fixes Project-MONAI#7585  .

### Description

Because the NNI test takes too much time, the previous behavior did not
get caught with the dry-run mode of HPO Gen

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

---------

Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
@mingxin-zheng mingxin-zheng deleted the fix-7585-nni branch April 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto3DSeg AutoRunner HPO training would save model checkpoint to wrong locations
2 participants