Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Dec 28, 2023

Fixes #7335

Description

Update openslide-python version

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 28, 2023

Hi @drbeh, I noticed you pinned the openslide-python's version in this #1548.
I tried the latest version and all unit tests can pass. Do we have any particular reason to pin the version?

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 28, 2023

/build

Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhashemian bhashemian merged commit f5327ad into Project-MONAI:dev Dec 28, 2023
@KumoLiu KumoLiu deleted the openslide branch December 28, 2023 14:23
marksgraham pushed a commit to marksgraham/MONAI that referenced this pull request Jan 30, 2024
Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this pull request Mar 25, 2024
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
vgrau98 pushed a commit to vgrau98/MONAI that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support newer openslide-python version that has available whls for newer python versions

2 participants