Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6638 use np.prod instead of np.product #6639

Merged
merged 2 commits into from
Jun 22, 2023
Merged

6638 use np.prod instead of np.product #6639

merged 2 commits into from
Jun 22, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jun 21, 2023

Fixes #6638

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes Project-MONAI#6638
d8e6daf 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
ericspod
ericspod approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wyli
Copy link
Contributor Author

wyli commented Jun 22, 2023

/build

@wyli wyli enabled auto-merge (squash) June 22, 2023 13:38
@wyli wyli merged commit ca9c36b into Project-MONAI:dev Jun 22, 2023
@wyli wyli deleted the 6638-deprecated-remove branch June 22, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

np.product is deprecated. Use np.prod instead.
2 participants
@wyli @ericspod