BoxToMask - explicit check for box extending over image shape #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
thanks! please sign https://github.com/Project-MONAI/MONAI/pull/6637/checks
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
kretes
force-pushed
the
box_to_mask_explicit_error
branch
from
582baf4
to
2ecd048
Compare
|
/build |
|
/build |
1 similar comment
|
/build |
drbeh
pushed a commit
to drbeh/MONAI
that referenced
this pull request
Jun 26, 2023
…t-MONAI#6637) Fixes an unclear error message when BoxToMask is called with box extending over passed spatial shape. Currently user face a numpy value broadcast error. ### Description An explicit check for box values vs `spatial_size` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unclear error message when BoxToMask is called with box extending over passed spatial shape. Currently user face a numpy value broadcast error.
Description
An explicit check for box values vs
spatial_sizeTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.