Add transform to handle empty box as training data #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Can Zhao <canz@nvidia.com>
…ng, especially when input box is empty Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Can-Zhao
force-pushed
the
negbox
branch
3 times, most recently
from
ed52ac9
to
7a92b22
Compare
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
wyli
reviewed
Mar 23, 2023
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
|
/build |
wyli
approved these changes
Mar 24, 2023
|
/build |
1 similar comment
|
/build |
jak0bw
pushed a commit
to jak0bw/MONAI
that referenced
this pull request
Mar 28, 2023
Fixes Project-MONAI#5990 . ### Description Add transforms to convert empty box with shape (0,M) or (0,) into (0,4) or (0,6). Provide format checking inside detector so users can know how to solve the format issue with empty box input. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Can Zhao <canz@nvidia.com>
jak0bw
pushed a commit
to jak0bw/MONAI
that referenced
this pull request
Mar 28, 2023
Fixes Project-MONAI#5990 . ### Description Add transforms to convert empty box with shape (0,M) or (0,) into (0,4) or (0,6). Provide format checking inside detector so users can know how to solve the format issue with empty box input. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Can Zhao <canz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5990 .
Description
Add transforms to convert empty box with shape (0,M) or (0,) into (0,4) or (0,6).
Provide format checking inside detector so users can know how to solve the format issue with empty box input.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.