Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GeneralizedDiceLoss #5468

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix GeneralizedDiceLoss #5468

merged 1 commit into from
Nov 4, 2022

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Nov 4, 2022 •
edited
Loading

Signed-off-by: KumoLiu yunl@nvidia.com

Fixes #5466.

Description

In GeneralizedDiceLoss, now it do channel reduction before reduction, remove channel reduction in this PR.

MONAI/monai/losses/dice.py

Lines 360 to 363 in c38d503

final_reduce_dim = 0 if self.batch else 1
numer = 2.0 * (intersection * w).sum(final_reduce_dim, keepdim=True) + self.smooth_nr
denom = (denominator * w).sum(final_reduce_dim, keepdim=True) + self.smooth_dr
f: torch.Tensor = 1.0 - (numer / denom)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#5466
b32d64c 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from wyli, Nic-Ma, ericspod and rijobro and removed request for wyli November 4, 2022 10:31
@KumoLiu KumoLiu mentioned this pull request Nov 4, 2022
Closed
@wyli
Copy link
Contributor

wyli commented Nov 4, 2022

/build

@wyli wyli enabled auto-merge (squash) November 4, 2022 13:39
@wyli wyli merged commit e03ecd4 into Project-MONAI:dev Nov 4, 2022
@KumoLiu KumoLiu deleted the fix-generalized-dice-loss branch November 4, 2022 14:51
wyli pushed a commit that referenced this pull request Nov 6, 2022
@KumoLiu @wyli
fix GeneralizedDiceLoss (#5468)
531a631 
Signed-off-by: KumoLiu <yunl@nvidia.com>

Fixes #5466.

### Description
In `GeneralizedDiceLoss`, now it do channel reduction before reduction,
remove channel reduction in this PR.

https://github.com/Project-MONAI/MONAI/blob/c38d503a587f1779914bd071a1b2d66a6d9080c2/monai/losses/dice.py#L360-L363

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli added a commit to wyli/MONAI that referenced this pull request Jul 25, 2023
@wyli
Revert "fix GeneralizedDiceLoss (Project-MONAI#5468)"
8bb0fae 
This reverts commit e03ecd4.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit to wyli/MONAI that referenced this pull request Jul 26, 2023
@wyli
Revert "fix GeneralizedDiceLoss (Project-MONAI#5468)"
541151c 
This reverts commit e03ecd4.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalized Dice Loss - Reduction="none" + batch=True
2 participants
@KumoLiu @wyli