-
Notifications
You must be signed in to change notification settings - Fork 1.2k
4862 Enhance docstring for the regular 2D image dims #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
Looks good though we should say that readers in general may reorder dimensions to match CHWD Pytorch ordering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes but it's a good reminder to people, thanks!
Signed-off-by: Nic Ma <nma@nvidia.com>
Hi @ericspod , Thanks for your review. Thanks. |
/black |
/build |
/build |
Fixes #4862 .
Description
This PR enhanced the doc-string of LoadImage according to the suggestion from @ericspod , for the regular 2D image dims.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.