Skip to content

4862 Enhance docstring for the regular 2D image dims #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 11, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 11, 2022

Fixes #4862 .

Description

This PR enhanced the doc-string of LoadImage according to the suggestion from @ericspod , for the regular 2D image dims.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, wyli and rijobro August 11, 2022 08:17
@ericspod
Copy link
Member

Looks good though we should say that readers in general may reorder dimensions to match CHWD Pytorch ordering. PILReader does this but others do something similar like here.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes but it's a good reminder to people, thanks!

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2022

Hi @ericspod ,

Thanks for your review.
I updated according to your comments, I didn't put "readers in general may reorder dimensions to match CHWD Pytorch ordering. PILReader does this but others do something similar like here.", because I feel "match CHWD PyTorch ordering" is slightly confusing..
Or do you have any other comments?

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2022

/build

@wyli
Copy link
Contributor

wyli commented Aug 11, 2022

/build

@wyli wyli enabled auto-merge (squash) August 11, 2022 11:28
@wyli wyli merged commit 77a45b8 into Project-MONAI:dev Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Documentation of LoadImage to Clarify Image Transposition
3 participants