Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

191 develop determinism integration test #195

Merged
merged 7 commits into from
Mar 20, 2020
Merged

191 develop determinism integration test #195

merged 7 commits into from
Mar 20, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 20, 2020

Fixes #191 .

Description

This PR implemented a determinism integration test and fixed several small bugs.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

wyli
wyli reviewed Mar 20, 2020
View reviewed changes
tests/integration_determinism.py Outdated Show resolved Hide resolved
tests/integration_determinism.py Outdated Show resolved Hide resolved
tests/integration_determinism.py Show resolved Hide resolved
tests/integration_determinism.py Show resolved Hide resolved
tests/integration_determinism.py Outdated Show resolved Hide resolved
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 20, 2020

@wyli thanks for your review.
I already updated the code according to the comments.
Could you please check it again?
Thanks.

@wyli wyli merged commit d191b09 into master Mar 20, 2020
@wyli wyli deleted the 191-develop-determinism-integration-test branch March 25, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

develop determinism integration test
2 participants
@Nic-Ma @wyli