Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152-random-rotate #155

Merged
merged 3 commits into from
Mar 10, 2020
Merged

152-random-rotate #155

merged 3 commits into from
Mar 10, 2020

Conversation

madil90
Copy link
Contributor

@madil90 madil90 commented Mar 7, 2020

Adds RandomRotate for #152 .

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@madil90 madil90 requested review from wyli and Nic-Ma March 7, 2020 00:20
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put several comments inline.
Thanks.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.
Thanks.

@wyli wyli merged commit d166f6a into master Mar 10, 2020
@wyli wyli deleted the 152-random-rotate branch May 21, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants