Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

133 dataset and example with dict transforms #134

Merged
merged 6 commits into from
Mar 5, 2020
Merged

133 dataset and example with dict transforms #134

merged 6 commits into from
Mar 5, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 3, 2020 •
edited
Loading

Fixes #133 .

Description

This PR implemented below items:

  1. Added a dict level transform: AddChanneld and the unit test.
  2. Added support to dict level transforms in NiftiDataset.
  3. Developed UNet 3D training & validation examples based on NiftiDataset and dict transforms.
  4. Fixed a numpy data error in RandomRotate90 transform.
  5. Unified "DataElementKeys" and "ImageProperties" as constants.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma force-pushed the 133-dataset-example-dict-transforms branch from 84ae2cc to f5cca26 Compare March 4, 2020 03:32
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 4, 2020

I updated this PR to split NiftiDataset and NifitDatasetd directly according to @wyli 's comments.
Could you please help review again and share comments if you have?
Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 5, 2020

Hi @wyli @ericspod @atbenmurray ,

I fixed conflicts with master branch and removed constants, let's discuss constants after GTC.
Could you please help review it again?
Thank.

wyli
wyli approved these changes Mar 5, 2020
View reviewed changes
monai/data/nifti_reader.py Outdated Show resolved Hide resolved
monai/data/nifti_reader.py Outdated Show resolved Hide resolved
@wyli wyli merged commit 7f29477 into master Mar 5, 2020
@wyli wyli deleted the 133-dataset-example-dict-transforms branch May 21, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dataset and train example with dict transforms
2 participants
@Nic-Ma @wyli