110-rotation #126
110-rotation #126
Conversation
|
@wyli @ericspod Same behavior as #125 (comment) replicated here. Resolution of that comment will be applied. |
monai/transforms/transforms.py
Outdated
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| import torch | |||
| import numpy as np | |||
| from skimage.transform import rotate | |||
There was a problem hiding this comment.
skimage isn't listed as a dependency in requirements.txt, an import won't be possible if it's missing. We should add it or scipy to requirements.
There was a problem hiding this comment.
Also, as briefly discussed in #112 (comment), pytorch provides a handy grid_sample function which seems also much more efficient than skimage.transform (at least for generic warps in 2D). See https://colab.research.google.com/drive/17pI6xPGLTGcpGBulBrWZeNnBfLAwzqZT
There was a problem hiding this comment.
strangely the CI test passed without modifying requirements.txt, @IsaacYangSLA looks like the CI docker image has common packages preinstalled, could we have a minimal docker image instead?
There was a problem hiding this comment.
Updated to use scipy.ndimage. Scikit-image doesn't work for 3D images properly. Also added to requirements and test.
There was a problem hiding this comment.
@tvercaut That request is being handled in another PR.
madil90
force-pushed
the
110-rotation
branch
2 times, most recently
from
635bd9e
to
25fae0f
Compare
Fixes #110 .
Description
Add the rotation transform. Tests coming soon.
Status
Work in progress
Types of changes