Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD Improvements #7250

Closed
ericspod opened this issue Nov 21, 2023 · 2 comments
Closed

CI/CD Improvements #7250

ericspod opened this issue Nov 21, 2023 · 2 comments
Labels
CI/CD enhancement New feature or request

Comments

@ericspod
Copy link
Member

Is your feature request related to a problem? Please describe.
There are a number of things with our CI/CD setup that could be optimised or fixed.

  • The environment-dev.yml file isn't well tested for various environments. For example, on Ubuntu 20.04 trying to create a new environment with conda env create -f environment-dev.yml requires hours to resolve the environment configuration, and then fails when attempting to build tokenizers which is used by transformers. This is caused by there being no pre-build wheels for Python 3.11 which is what the environment file will select by default. Our CI/CD system doesn't seem to catch this kind of issue.
  • Currently the full tests with every dependency installed only use Python 3.8, this version will be dropped soon but all supported versions should be checked with these tests weekly to catch the above issue.
  • The versions of libraries mentioned in requirements/environments, such as Pytorch or Numpy, files should be upgraded to more recent ones on a set schedule.
  • What tests to run can be set in the workflows so that tests can be skipped when files which aren't source or unit tests are changed, eg. when changing docs. This can be done with Actions syntax.
@ericspod ericspod added the enhancement New feature or request label Nov 21, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Dec 1, 2023
@KumoLiu
fix Project-MONAI#7250
22ed5d6 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this issue Dec 1, 2023
Merged
7 tasks
@KumoLiu
Copy link
Contributor

KumoLiu commented Dec 1, 2023

Currently the full tests with every dependency installed only use Python 3.8, this version will be dropped soon but all supported versions should be checked with these tests weekly to catch the above issue.

There are more daily tests tested in Blossom. We may update the version when it dropped.

@KumoLiu KumoLiu added the CI/CD label Dec 4, 2023
KumoLiu added a commit that referenced this issue Dec 5, 2023
@KumoLiu
update the Python version requirements for transformers (#7275)
88f8dd2 
Part of #7250.

### Description
Fix the Python version for transformers smaller than 3.10.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
@vikashg
Copy link

vikashg commented Jan 4, 2024

closing seems to have merged @KumoLiu @ericspod

@vikashg vikashg closed this as completed Jan 4, 2024
marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
@KumoLiu @marksgraham
update the Python version requirements for transformers (Project-MONA…
11c1285 
…I#7275)

Part of Project-MONAI#7250.

### Description
Fix the Python version for transformers smaller than 3.10.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
@KumoLiu @juampatronics
update the Python version requirements for transformers (Project-MONA…
9802109 
…I#7275)

Part of Project-MONAI#7250.

### Description
Fix the Python version for transformers smaller than 3.10.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
@KumoLiu @Yu0610
update the Python version requirements for transformers (Project-MONA…
cf1c70d 
…I#7275)

Part of Project-MONAI#7250.

### Description
Fix the Python version for transformers smaller than 3.10.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
vgrau98 pushed a commit to vgrau98/MONAI that referenced this issue Apr 28, 2024
@KumoLiu @vgrau98
update the Python version requirements for transformers (Project-MONA…
7531b5c 
…I#7275)

Part of Project-MONAI#7250.

### Description
Fix the Python version for transformers smaller than 3.10.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD enhancement New feature or request
Projects
No open projects
MONAI v1.4
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vikashg @ericspod @KumoLiu