Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecating tests for python3.7, torch1.8.* #6166

Closed
wyli opened this issue Mar 17, 2023 · 0 comments · Fixed by #6227
Closed

deprecating tests for python3.7, torch1.8.* #6166

wyli opened this issue Mar 17, 2023 · 0 comments · Fixed by #6227
Labels
enhancement New feature or request

Comments

@wyli
Copy link
Contributor

wyli commented Mar 17, 2023

Is your feature request related to a problem? Please describe.
with new tests in #6152, now removing tests for

  • python3.7 end of life 27 Jun 2023
  • torch 1.8.* and cuda10.2
@wyli wyli added the enhancement New feature or request label Mar 17, 2023
@wyli wyli mentioned this issue Mar 22, 2023
Merged
7 tasks
wyli added a commit that referenced this issue Mar 23, 2023
@wyli
6166 drop py37 and torch 1.8 (#6227)
104a360 
Fixes #6166

### Description
- reviewed the package metadata
- keep testing and code logic

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
jak0bw pushed a commit to jak0bw/MONAI that referenced this issue Mar 28, 2023
@wyli @jak0bw
6166 drop py37 and torch 1.8 (Project-MONAI#6227)
9e57176 
Fixes Project-MONAI#6166

### Description
- reviewed the package metadata
- keep testing and code logic

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
jak0bw pushed a commit to jak0bw/MONAI that referenced this issue Mar 28, 2023
@wyli @jak0bw
6166 drop py37 and torch 1.8 (Project-MONAI#6227)
ebbeff9 
Fixes Project-MONAI#6166

### Description
- reviewed the package metadata
- keep testing and code logic

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

6166 drop py37 and torch 1.8 wyli/MONAI
1 participant
@wyli