Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_get_latest_bundle_version issue on Windows #5775

Closed
yiheng-wang-nv opened this issue Dec 20, 2022 · 0 comments · Fixed by #5787
Closed

_get_latest_bundle_version issue on Windows #5775

yiheng-wang-nv opened this issue Dec 20, 2022 · 0 comments · Fixed by #5787
Assignees
@yiheng-wang-nv

Comments

@yiheng-wang-nv
Copy link
Contributor

MONAI/monai/bundle/scripts.py

Line 185 in 69463a6

return get_bundle_versions(name, repo=os.path.join(repo_owner, repo_name), tag=tag_name)["latest_version"]

On Windows, os.path.join will produce backslash rather than slash. Therefore, the created url will be wrong (os.path.join(repo_owner, repo_name))
May need to handle this to avoid issues for Windows users.
@yiheng-wang-nv yiheng-wang-nv self-assigned this Dec 20, 2022
@yiheng-wang-nv yiheng-wang-nv mentioned this issue Dec 26, 2022
Merged
7 tasks
@wyli wyli closed this as completed in #5787 Jan 4, 2023
wyli pushed a commit that referenced this issue Jan 4, 2023
@yiheng-wang-nv
5775 Fix _get_latest_bundle_version issue on Windows (#5787)
c6081e5 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>

Fixes #5775 .

### Description

This PR fixes the issue of `_get_latest_bundle_version` on Windows
(`os.path.join` will produce backslash which will create a wrong url)
Thanks @SachidanandAlle for finding this issue.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiheng-wang-nv yiheng-wang-nv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5775 Fix _get_latest_bundle_version issue on Windows yiheng-wang-nv/MONAI
1 participant
@yiheng-wang-nv