Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a DICOM loader #135

Closed
wyli opened this issue Mar 3, 2020 · 10 comments
Closed

add a DICOM loader #135

wyli opened this issue Mar 3, 2020 · 10 comments
Assignees
Labels
Module: data datasets, readers/writers, synthetic data working group needs working group discussions

Comments

@wyli
Copy link
Contributor

wyli commented Mar 3, 2020

Nibabal is used to load Nifti files,
would be great to have preliminary support of loading DICOM (using pydicom)

@mhubii
Copy link
Contributor

mhubii commented Mar 19, 2020

is this still an open issue? Happy to contribute here as well

@wyli
Copy link
Contributor Author

wyli commented Mar 19, 2020

yes it is, would be great to have it in a similar format to LoadNifti
https://github.com/Project-MONAI/MONAI/blob/master/monai/transforms/transforms.py#L140

@mhubii
Copy link
Contributor

mhubii commented Mar 19, 2020

all right. Would it belong to data where the Dataset is also generated https://github.com/Project-MONAI/MONAI/blob/master/monai/data/nifti_reader.py?

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 20, 2020

Hi @mhubii ,

Glad to see your contribution here!

  1. Please develop a LoadDICOM/LoadDICOMd transform referring to the LoadNifti/LoadNiftid transform as Wenqi said:
    https://github.com/Project-MONAI/MONAI/blob/master/monai/transforms/transforms.py#L140
    https://github.com/Project-MONAI/MONAI/blob/master/monai/transforms/composables.py#L116
    You can also check this example to see how to use the LoadNiftid transform:
    https://github.com/Project-MONAI/MONAI/blob/master/examples/integrate_to_spleen_program.ipynb
  2. I will try to refactor the nifti_reader Dataset to be compatible with common Dataset soon:
    https://github.com/Project-MONAI/MONAI/blob/master/monai/data/dataset.py
  3. And we already have a WIP PR WIP(convert tool to transform)-135 add DICOM loader #141 that contains a DICOM reader tool, you can leverage the code to contribute to that branch or create a new PR as you like.

Thanks.

@aylward
Copy link
Collaborator

aylward commented Apr 30, 2020

Support for ITK Python (and SimpleITK). ITK Python provides direct support for numpy arrays, xarrays, and other data formats. It also exposes more of ITK and is more "pythonic" than SimpleITK. See
ITK Python Quick Start

@wyli wyli added working group needs working group discussions Module: data datasets, readers/writers, synthetic data labels May 15, 2020
@pfdamasceno
Copy link

Hi all, I'd happy to contribute as well.

In particular, after reading the DICOM, properly sorting slices can be a bit tricky. Is this a useful / desired feature?

@aylward
Copy link
Collaborator

aylward commented Jul 6, 2020 via email

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jul 6, 2020

Hi @mjorgecardoso ,

Could you please help share the latest status of DICOM discussion in our IO working group?
Thanks.

@aylward
Copy link
Collaborator

aylward commented Jul 6, 2020 via email

@jond01 jond01 mentioned this issue Jul 30, 2020
@wyli
Copy link
Contributor Author

wyli commented Aug 19, 2020

closing this in favour of #856

@wyli wyli closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: data datasets, readers/writers, synthetic data working group needs working group discussions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants