Skip to content

Commit

Permalink
Versions as strings, not numbers, so that 3.1 != 3.10, etc. (#5456)
Browse files Browse the repository at this point in the history
Signed-off-by: Lee Newberg <lee.newberg@kitware.com>

### Description

Re-writes version numbers as strings rather than numbers because 3.1 !=
3.10, etc. Nothing is broken at present but in the future as, e.g., the
Python version for some things goes from 3.8 to 3.9 to 3.10, this could
end up being an unexpected problem.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>
  • Loading branch information
Leengit authored Nov 2, 2022
1 parent fc66dff commit b05ef9c
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/blossom-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
#- name: Setup java
# uses: actions/setup-java@v1
# with:
# java-version: 1.8
# java-version: '1.8'

# add blackduck properties https://synopsys.atlassian.net/wiki/spaces/INTDOCS/pages/631308372/Methods+for+Configuring+Analysis#Using-a-configuration-file
#- name: Setup blackduck properties
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cron-mmar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: cache weekly timestamp
id: pip-cache
run: echo "datew=$(date '+%Y-%V')" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: [self-hosted, linux, x64, common]
strategy:
matrix:
pytorch-version: [1.7.1, 1.8.1, 1.9.1, 1.10.2, latest]
pytorch-version: ['1.7.1', '1.8.1', '1.9.1', '1.10.2', 'latest']
steps:
- uses: actions/checkout@v3
- name: Install the dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- shell: bash
run: |
git describe
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pythonapp-min.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: Prepare pip wheel
run: |
which python
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
python-version: ['3.7', '3.8', '3.9', '3.10']
timeout-minutes: 40
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -119,14 +119,14 @@ jobs:
strategy:
fail-fast: false
matrix:
pytorch-version: [1.7.1, 1.8.2, 1.9.1, 1.10.2, 1.11.0, latest]
pytorch-version: ['1.7.1', '1.8.2', '1.9.1', '1.10.2', '1.11.0', 'latest']
timeout-minutes: 40
steps:
- uses: actions/checkout@v3
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: Prepare pip wheel
run: |
which python
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: cache weekly timestamp
id: pip-cache
run: |
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: Prepare pip wheel
run: |
which python
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: cache weekly timestamp
id: pip-cache
run: |
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: cache weekly timestamp
id: pip-cache
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
python-version: ['3.7', '3.8', '3.9', '3.10']
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- shell: bash
run: |
git describe
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/setupapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
python-version: ['3.7', '3.8', '3.9', '3.10']
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: cache weekly timestamp
id: pip-cache
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/weekly-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: '3.8'
- name: Install setuptools
run: |
python -m pip install --user --upgrade setuptools wheel
Expand Down

0 comments on commit b05ef9c

Please sign in to comment.