Skip to content

Commit

Permalink
Pin gdown version to v4.6.3 (#7384)
Browse files Browse the repository at this point in the history
Workaround for #7382 #7383

### Description

Based on the comment
[here](wkentaro/gdown#291 (comment)),
pin the gdown version as a workaround. Will review this one once gdown
has some update internal.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
  • Loading branch information
KumoLiu authored Jan 12, 2024
1 parent e1ffa7e commit 25f1901
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion monai/apps/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from monai.config.type_definitions import PathLike
from monai.utils import look_up_option, min_version, optional_import

gdown, has_gdown = optional_import("gdown", "4.4")
gdown, has_gdown = optional_import("gdown", "4.6.3")

if TYPE_CHECKING:
from tqdm import tqdm
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Full requirements for developments
-r requirements-min.txt
pytorch-ignite==0.4.11
gdown>=4.4.0
gdown>=4.4.0, <=4.6.3
scipy>=1.7.1
itk>=5.2
nibabel
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ all =
scipy>=1.7.1
pillow
tensorboard
gdown>=4.4.0
gdown==4.6.3
pytorch-ignite==0.4.11
torchvision
itk>=5.2
Expand Down Expand Up @@ -97,7 +97,7 @@ pillow =
tensorboard =
tensorboard
gdown =
gdown>=4.4.0
gdown==4.6.3
ignite =
pytorch-ignite==0.4.11
torchvision =
Expand Down

0 comments on commit 25f1901

Please sign in to comment.