Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken download link in test_bundle_download #7383

Closed
KumoLiu opened this issue Jan 10, 2024 · 2 comments · Fixed by #7448
Closed

Broken download link in test_bundle_download #7383

KumoLiu opened this issue Jan 10, 2024 · 2 comments · Fixed by #7448
Labels
bug Something isn't working

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 10, 2024

[2024-01-10T00:38:35.456Z] ERROR: test_url_download_large_files_0 (tests.test_bundle_download.TestDownloadLargefiles)
[2024-01-10T00:38:35.456Z] ----------------------------------------------------------------------
[2024-01-10T00:38:35.456Z] Traceback (most recent call last):
[2024-01-10T00:38:35.456Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/tests/utils.py", line 807, in command_line_tests
[2024-01-10T00:38:35.456Z]     normal_out = subprocess.run(cmd, env=test_env, check=True, capture_output=True)
[2024-01-10T00:38:35.456Z]   File "/opt/conda/lib/python3.8/subprocess.py", line 516, in run
[2024-01-10T00:38:35.456Z]     raise CalledProcessError(retcode, process.args,
[2024-01-10T00:38:35.456Z] subprocess.CalledProcessError: Command '['coverage', 'run', '-m', 'monai.bundle', 'download_large_files', '--bundle_path', '/tmp/tmp0oa200eb/test_bundle']' returned non-zero exit status 1.
[2024-01-10T00:38:35.456Z] 
[2024-01-10T00:38:35.456Z] The above exception was the direct cause of the following exception:
[2024-01-10T00:38:35.456Z] 
[2024-01-10T00:38:35.456Z] Traceback (most recent call last):
[2024-01-10T00:38:35.456Z]   File "/opt/conda/lib/python3.8/site-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-01-10T00:38:35.456Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-01-10T00:38:35.456Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/tests/test_bundle_download.py", line 360, in test_url_download_large_files
[2024-01-10T00:38:35.456Z]     command_line_tests(cmd)
[2024-01-10T00:38:35.456Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/tests/utils.py", line 813, in command_line_tests
[2024-01-10T00:38:35.456Z]     raise RuntimeError(f"subprocess call error {e.returncode}: {errors}, {output}") from e
[2024-01-10T00:38:35.456Z] RuntimeError: subprocess call error 1: b'Traceback (most recent call last):
[2024-01-10T00:38:35.456Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/bundle/__main__.py", line 31, in <module>
[2024-01-10T00:38:35.456Z]     fire.Fire()
[2024-01-10T00:38:35.456Z]   File "/opt/conda/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
[2024-01-10T00:38:35.456Z]     component_trace = _Fire(component, args, parsed_flag_args, context, name)
[2024-01-10T00:38:35.456Z]   File "/opt/conda/lib/python3.8/site-packages/fire/core.py", line 475, in _Fire
[2024-01-10T00:38:35.456Z]     component, remaining_args = _CallAndUpdateTrace(
[2024-01-10T00:38:35.456Z]   File "/opt/conda/lib/python3.8/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
[2024-01-10T00:38:35.457Z]     component = fn(*varargs, **kwargs)
[2024-01-10T00:38:35.457Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/bundle/scripts.py", line 1797, in download_large_files
[2024-01-10T00:38:35.457Z]     download_url(**lf_data)
[2024-01-10T00:38:35.457Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/apps/utils.py", line 208, in download_url
[2024-01-10T00:38:35.457Z]     gdown.download(url, f"{tmp_name}", quiet=not progress, **gdown_kwargs)
[2024-01-10T00:38:35.457Z]   File "/opt/conda/lib/python3.8/site-packages/gdown/download.py", line 259, in download
[2024-01-10T00:38:35.457Z]     filename_from_url = m.groups()[0]
[2024-01-10T00:38:35.457Z] AttributeError: \'NoneType\' object has no attribute \'groups\'
[2024-01-10T00:38:35.457Z] ', b''
@KumoLiu KumoLiu added the bug Something isn't working label Jan 10, 2024
@KumoLiu KumoLiu assigned KumoLiu and unassigned KumoLiu Jan 10, 2024
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 10, 2024

Looks like the bug described here.
wkentaro/gdown#43

The permissions on the file have been set to ``Anyone with the link''.
The problems, according to wkentaro/gdown#43 (comment), there are some limitations for access without OAuth to Google Drive and gdown cannot resolve it.

Do you have alternatives here? cc @ericspod @Nic-Ma

KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Jan 12, 2024
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
ericspod pushed a commit that referenced this issue Jan 12, 2024
Workaround for #7382 #7383

### Description

Based on the comment
[here](wkentaro/gdown#291 (comment)),
pin the gdown version as a workaround. Will review this one once gdown
has some update internal.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

The gdown version pin should fix this issue.

marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
Workaround for Project-MONAI#7382 Project-MONAI#7383

### Description

Based on the comment
[here](wkentaro/gdown#291 (comment)),
pin the gdown version as a workaround. Will review this one once gdown
has some update internal.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
@KumoLiu KumoLiu mentioned this issue Feb 7, 2024
7 tasks
KumoLiu added a commit that referenced this issue Feb 7, 2024
gdown library has been updated to fix
#7383 since
wkentaro/gdown#295
Update the gdown version for this PR
#7384

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
Workaround for Project-MONAI#7382 Project-MONAI#7383

### Description

Based on the comment
[here](wkentaro/gdown#291 (comment)),
pin the gdown version as a workaround. Will review this one once gdown
has some update internal.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
gdown library has been updated to fix
Project-MONAI#7383 since
wkentaro/gdown#295
Update the gdown version for this PR
Project-MONAI#7384

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
Workaround for Project-MONAI#7382 Project-MONAI#7383

### Description

Based on the comment
[here](wkentaro/gdown#291 (comment)),
pin the gdown version as a workaround. Will review this one once gdown
has some update internal.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
gdown library has been updated to fix
Project-MONAI#7383 since
wkentaro/gdown#295
Update the gdown version for this PR
Project-MONAI#7384

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants