Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Allowing sample clipping values besides clip_sample True/False - #495

Merged
ericspod merged 1 commit into
mainfrom
494-clipping-min-and-max-values-on-scheduler
Jun 21, 2024
Merged

ericspod merged 1 commit into
mainfrom
494-clipping-min-and-max-values-on-scheduler

Conversation

@virginiafdez

Copy link
Copy Markdown
Contributor

In response to discussion #492 and issue #494:

  • modification of DDPM and DDIM. We added arguments clip_sample_min and clip_sample_max, so that the user can choose to clip, but specify by which values (originally, it was done with -1 and 1, but this has proven ineffective with certain image ranges and with latent models).
  • VQ-VAE was missing an import
  • Patch-GAN and VQVAE have been reformatted after running autofix.

…choose the clipping values. We added arguments clip_value_min and clip_value_max.

Ran autofix (formatted patchgan and vqvae).

VQ-VAE was missing an import (from my side).

Signed-off-by: virginiafdez <virginia.fernandez@kcl.ac.uk>
@virginiafdez virginiafdez linked an issue Jun 2, 2024 that may be closed by this pull request
@virginiafdez virginiafdez self-assigned this Jun 19, 2024
@virginiafdez
virginiafdez requested a review from ericspod June 21, 2024 09:41
@ericspod
ericspod merged commit 5672a90 into main Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clipping min and max values on scheduler

2 participants