Skip to content

Conversation

@LinkMaq
Copy link

@LinkMaq LinkMaq commented Dec 23, 2025

As described in the title, there is a little issue in the document.

Copilot AI review requested due to automatic review settings December 23, 2025 07:11
@hami-robot hami-robot bot requested a review from archlitchi December 23, 2025 07:11
@hami-robot
Copy link
Contributor

hami-robot bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LinkMaq
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link
Contributor

hami-robot bot commented Dec 23, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 0a43e8d Fix imageTag to image.tag in installation command
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hami-robot hami-robot bot requested a review from wawa0210 December 23, 2025 07:11
@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 0a43e8d
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/694a40865fee0e0008a5dc5d
😎 Deploy Preview https://deploy-preview-121--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot
Copy link
Contributor

hami-robot bot commented Dec 23, 2025

Welcome @LinkMaq! It looks like this is your first PR to Project-HAMi/website 🎉

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Helm installation parameter from scheduler.kubeScheduler.imageTag to scheduler.kubeScheduler.image.tag in the online installation documentation. This aligns with the nested structure shown in the Helm chart values where kubeScheduler.image is an object with a tag property.

Key Changes

  • Updated the helm install command parameter syntax to use the correct nested property path scheduler.kubeScheduler.image.tag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


```bash
helm install hami hami-charts/hami --set scheduler.kubeScheduler.imageTag=v1.16.8 -n kube-system
helm install hami hami-charts/hami --set scheduler.kubeScheduler.image.tag=v1.16.8 -n kube-system
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from scheduler.kubeScheduler.imageTag to scheduler.kubeScheduler.image.tag creates an inconsistency with line 25, which still references scheduler.kubeScheduler.imageTag. If image.tag is the correct parameter format, line 25 should also be updated to maintain consistency within this documentation.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant