Skip to content

Edit Profile and Owner's Info tab fixed #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2021

Conversation

keyurgit45
Copy link
Contributor

Description

Summary of the changes and which issue is fixed.
Now Edit profile and owners tab is working. A new profile can be updated. Also in location helper removed the state field instead added street address because we can't get state using geocode package. Existing accounts may not work after this. I tested using a new account, it's working fine.

Fixes #79

Type of change

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • My code follows the code of conduct of this project

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • My changes generate no new warnings

@Mohitmadhav
Copy link
Member

image
@keyurgit45

@Mohitmadhav
Copy link
Member

The explore nearby page in itself has some faults for which I'll create other issues after this gets resolved

@Mohitmadhav Mohitmadhav reopened this Oct 29, 2021
@keyurgit45
Copy link
Contributor Author

image
@keyurgit45

Is this error coming after clicking on owner info tab?

@Mohitmadhav
Copy link
Member

Yes yes @keyurgit45

@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 29, 2021

@Mohitmadhav Can you check in the firebase database if the userid field of that book contains the correct userid and is not empty in books collections and the same user is present in the users collection? If present, try adding the same book again

@Mohitmadhav
Copy link
Member

Yeah, @keyurgit45 there's no field of userid in that book.
There might be many books like that.

image

@keyurgit45
Copy link
Contributor Author

Yeah, @keyurgit45 there's no field of userid in that book.
There might be many books like that.

image

May be these books were added in early stage of the app.. So you can remove these books ig

@Mohitmadhav
Copy link
Member

I just deleted the whole collection because there were many books like these.
And I again added a book. Just check whether it's displaying in your app or not (For more than 20 km books)?

@keyurgit45
Copy link
Contributor Author

Screenshot_20211030_095247_com.example.books_app.jpg
It's working.. But if you delete the books collection you also need to delete ownedbooks collection from each users collections also.

@Mohitmadhav
Copy link
Member

I can delete the whole user collection also - It already has lot of junk from the past test users

@Mohitmadhav
Copy link
Member

@keyurgit45 I deleted the user collection too...
So just once test the release apk at your home among your family members to check this error...
Then I'll tell whether it gets displayed in my (>20 km) range or not

@keyurgit45
Copy link
Contributor Author

@Mohitmadhav have you deleted accounts from authentication tab on firebase?

@Mohitmadhav
Copy link
Member

No, just the user collection from Firestore

@keyurgit45
Copy link
Contributor Author

No, just the user collection from Firestore

Then delete that also otherwise it will create issues

@Mohitmadhav
Copy link
Member

Yeah I know @keyurgit45 but they have to be deleted one by one so didn't do so for now

@keyurgit45
Copy link
Contributor Author

Yeah I know @keyurgit45 but they have to be deleted one by one so didn't do so for now

Okay Fine! I am creating new account then Check if (Book info) it is showing on your phone or not .

@Mohitmadhav
Copy link
Member

Yeah I know @keyurgit45 but they have to be deleted one by one so didn't do so for now

Okay Fine! I am creating new account then Check if (Book info) it is showing on your phone or not .

I deleted all the accounts from Auth console using website inspect

@keyurgit45
Copy link
Contributor Author

@Mohitmadhav I have added books. check if these books are showing on your device correctly.

@Mohitmadhav
Copy link
Member

Yeah...now the Owner's info is sorted out.
So, the Provider context you have resolved.
Cool @keyurgit45 .
Now more feature issues are clearly visible.

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 31, 2021
@Mohitmadhav Mohitmadhav merged commit dd1379a into Project-Easter:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Profile and Owner's Info tab not working (Provider State Management)
2 participants