This repository was archived by the owner on Mar 25, 2023. It is now read-only.
Merged
Conversation
if you have more than one versions of java
Contributor
Author
|
Do I need to change something? |
knjk04
suggested changes
Jan 16, 2021
Member
knjk04
left a comment
knjk04
left a comment
There was a problem hiding this comment.
Thanks for working on this! I've left some comments for you to address
src/test/java/com/karankumar/booksapi/repository/BookRepositoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/karankumar/booksapi/repository/BookRepositoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/karankumar/booksapi/repository/BookRepositoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/karankumar/booksapi/repository/BookRepositoryTest.java
Show resolved
Hide resolved
src/main/java/com/karankumar/booksapi/repository/BookRepository.java
Outdated
Show resolved
Hide resolved
knjk04
approved these changes
Jan 18, 2021
Member
knjk04
left a comment
knjk04
left a comment
There was a problem hiding this comment.
Thanks for working on this! I've made a few small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of change
add a query for finding books by name and a test for this query
Related issue
Closes #10
Pull request checklist
Please keep this checklist in & ensure you have done the following:
Read, understood and adhered to our contributing document.
Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123Set this pull request to 'draft' if you are still working on it
Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace