Fix crash on model load and version increment #66
Conversation
Loading an incorrect model path will cause the app to load the default model rather than crash on startup. Incremented the app version from 2.0.6 Alpha to 2.1.0 Beta.
App will now load the default model and alert the user when an incorrect file path is specified rather than crashing on startup. Incremented the version number from 2.0.6 Alpha to 2.1.0 Beta
Fix crash on model load and version increment
|
Using this, it appears the user is prompted to choose a directory with the new "Browse" button. Is this the intended behavior? Or is the user expected to pick the model file as opposed to the directory |
|
The user is intended to pick a model directory just like before, now there is simply a file browser to make picking the model file easier. A model path can still be specified like before. |
Sorry, which one is this supposed to be here? Presently, if the user is expected to select a model file they are only able to choose a directory. |
|
The models we distribute are stored in a specific directory structure. The way we have always specified the model is by the directory. This is no different. |
|
Did some more testing here. Things are looking pretty good, I'll keep having a look at it, but I have no further comments at this time |
|
I believe this is ready to merge then. I just need you to complete the review. |
2 participants
App will now load the default model and alert the user when an incorrect file path is specified rather than crashing on startup.
Incremented the version number from 2.0.6 Alpha to 2.1.0 Beta
commit
Fix low frame rate by lowering timeout time.has had it's changes reverted, I can't seem to figure out how to remove it from my repo.