Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

This filter was added as part of the new Onboarding, to allow other plugins (like pp-hosts) to change when the onboarding should be displayed (by default it is shown on first (front or back end) page load after the plugin is installed).

Condition was set to filtered value was "should onboarding be skipped", but I think it is more clear to filter "should onboarding be displayed" value - so this PR just reverses that.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

✅ Code Coverage Report

Metric Value
Total Coverage 31.49% 📉
Base Coverage 31.49%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@ilicfilip ilicfilip merged commit 2c5d373 into develop Dec 24, 2025
21 checks passed
@ilicfilip ilicfilip deleted the filip/reverse-filter-logic branch December 24, 2025 10:40
@ilicfilip ilicfilip added this to the 1.10.0 milestone Jan 14, 2026
ilicfilip added a commit that referenced this pull request Jan 26, 2026
This reverts the new onboarding introduced in PR #714 and subsequent
onboarding-related PRs (#730, #733, #736, #741).

The new onboarding work is preserved in branch: filip/new-onboarding-preserved

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants