Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

This is something which is bugging me for some time now - interactive tasks add popover markup and enqueue (at least one) JavaScript file. But the issue is that they do it always when the class instance is created - it doesnt matter if the task is published or not (could be that it was completed long time ago).

Currently popovers add over 2000 lines of markup, <select> for set locale and timezone add most of it, which is often more than the rest of the page.

This PR adds a fix for it, by checking if a published task for specific task provider exists before adding popover and enqueueing JS file.

@aristath , if you have better name for newly added is_task_published method please rename it.

@ilicfilip ilicfilip added this to the 1.10.0 milestone Nov 5, 2025
@ilicfilip ilicfilip requested a review from aristath November 5, 2025 10:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Test on Playground
Test this pull request on the Playground
or download the zip

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

✅ Code Coverage Report

Metric Value
Total Coverage 24.01% 📉
Base Coverage 24.05%
Difference 📉 -0.04%

⚠️ Coverage below recommended 40% threshold

📊 File-level Coverage Changes (1 files)

📉 Coverage Decreased

Class Before After Change
Progress_Planner\Suggested_Tasks\Providers\Tasks_Interactive 7.53% 6.73% -0.80%
ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@aristath aristath merged commit 801abf0 into develop Nov 5, 2025
29 checks passed
@aristath aristath deleted the filip/v110/reduce-interactive-task-load branch November 5, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants