Dont enqueue assets or add popover if interactive task is not published #703
+30
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something which is bugging me for some time now - interactive tasks add popover markup and enqueue (at least one) JavaScript file. But the issue is that they do it always when the class instance is created - it doesnt matter if the task is published or not (could be that it was completed long time ago).
Currently popovers add over 2000 lines of markup,
<select>for set locale and timezone add most of it, which is often more than the rest of the page.This PR adds a fix for it, by checking if a published task for specific task provider exists before adding popover and enqueueing JS file.
@aristath , if you have better name for newly added
is_task_publishedmethod please rename it.