Fix missing JS global variable on WP Dashboard page (again) #690
+22
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test on Playground |
aristath
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the same issue as in #675, but since we converted more tasks to be interactive in #663 it occured for them too.
So I reverted the original fix and applied new one which defines
global progressPlannerJS variable, to fix it for all occurrences. I found this to be least invasive fix, as I didn't want to add onboarding URL and nonce (which we use with the variable of the same name on the PP Dashboard page).Also this PR fixes the mistake where completeTask property overrode the function with the same name in the
prpl-install-plugin.js. Now property has new (unique) name and function can be called without issues.