Skip to content

Adding filters to the application view#22

Merged
ianmiyazato merged 9 commits intomainfrom
feature/application-filters
Jan 30, 2026
Merged

Adding filters to the application view#22
ianmiyazato merged 9 commits intomainfrom
feature/application-filters

Conversation

@gianluca-pettenon
Copy link
Member

@gianluca-pettenon gianluca-pettenon commented Jan 20, 2026

Summary

  • Adding filters to the application view.

Type of Change

  • Feature
  • Fix
  • Improvement
  • Refactor
  • Documentation

Included Changes

  • frontend/src/features/applications/components/ApplicationsClientSection/index.tsx
  • frontend/src/features/applications/components/ApplicationsGrid/index.tsx
  • frontend/src/features/applications/components/SearchApplications.tsx
  • backend/app/presentation/schemas/application.py
  • backend/app/domain/models.py
  • backend/app/application/dto/application.py

Features

  • Adding filters to the application view

Testing

  • Unit tests
  • Integration tests
  • Manual testing
  • N/A

Checklist

  • Self-review completed
  • CI passing
  • Ready to merge

@gianluca-pettenon gianluca-pettenon added the enhancement New feature or request label Jan 20, 2026
@luis0ares luis0ares requested a review from ianmiyazato January 20, 2026 20:15
@gianluca-pettenon gianluca-pettenon marked this pull request as ready for review January 20, 2026 21:28
@gianluca-pettenon
Copy link
Member Author

Evidences

image image image image

Copy link
Contributor

@ianmiyazato ianmiyazato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your branch locally and tested the status filter functionality.
The feature works, but I noticed a few behavior points that could be refined to better align with the intended filter behavior.

Observed points:
• When selecting the “closed” status filter and there are no closed applications, the applications list is not updated/reflected correctly.
• After selecting a status filter, typing in the search input causes the previously selected status filter to be ignored.
• The inverse also happens: when searching first and then applying a status filter, the search input is no longer considered.

In addition, I made some local UX/UI improvements, including refinements to the button styling, dropdown behavior, and animations, to make the interaction clearer and more fluid.

With these adjustments, the status filter and search work together consistently, and the overall user experience improves.

We can proceed in one of two ways — whichever you prefer:

  • I can push my commits directly to your branch (if you’re okay with that), or
  • I can explain the main changes so you can apply them to the PR.

Let me know what you prefer so we can move forward in the best way.

@ianmiyazato
Copy link
Contributor

Thanks for the collaboration on this.

The refinement points discussed were addressed, and the status filter and search behavior are now aligned as expected.

Everything looks good - moving forward with the merge.

@ianmiyazato ianmiyazato merged commit a8ae8fe into main Jan 30, 2026
3 checks passed
@gianluca-pettenon gianluca-pettenon deleted the feature/application-filters branch January 30, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants