Fixes #3445: Close timers after resolving/erroring the dns.* promises

ProfessionallyEvil · Oct 26, 2020 · 07a6e2b · 07a6e2b
1 parent 33fbfb9
commit 07a6e2b
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/drivers/npm/driver.js b/src/drivers/npm/driver.js
@@ -637,17 +637,16 @@ class Site {
       // DNS
       if (!this.dns.length) {
         const records = {}
-
         const resolve = async (func, hostname) => {
-          try {
-            return await this.promiseTimeout(func(hostname))
-          } catch (error) {
-            if (error.code !== 'ENODATA') {
-              this.error(error)
-            }
+          return this.promiseTimeout(
+            func(hostname).catch((error) => {
+              if (error.code !== 'ENODATA') {
+                this.error(error)
+              }
 
-            return []
-          }
+              return []
+            })
+          )
         }
 
         const domain = url.hostname.replace(/^www\./, '')