Skip to content

Conversation

@gsiri-jack
Copy link

This PR enhances the user experience by adding proper UI feedback when saving rules fails due to API/network issues.

  • Added errorMessage reactive ref
  • Displayed error in <App.vue> using a styled banner
  • Included graceful fallback in watch(rules) to notify the user via mw.notify

Fixes ProfessionalWiki/Rules#43

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.62%. Comparing base (241a552) to head (93db5cc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     60.47%   61.62%   +1.14%     
- Complexity       63       64       +1     
============================================
  Files            11       11              
  Lines           167      172       +5     
============================================
+ Hits            101      106       +5     
  Misses           66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeroenDeDauw
Copy link
Member

@gsiri-jack did you test this in the browser? Could you post a screenshot of what it looks like?

Copy link
Contributor

@malberts malberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is clearly broken:
image

And JavaScript CI fails.

@gsiri-jack
Copy link
Author

@malberts Thanks for the catch! Fixed the return block and confirmed CI is passing now. Please review again. #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show error on UI when API save fails

4 participants