Add ExplainCypherQueryValidator #494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a CypherQueryValidator interface in the Application layer with two implementations: KeywordCypherQueryValidator (keyword-based filtering, formerly CypherQueryFilter) and ExplainCypherQueryValidator (EXPLAIN plan-based validation, formerly ExplainBasedQueryValidator). Add missing read-only operators (Unwind, NodeCountFromCountStore, RelationshipCountFromCountStore) to the EXPLAIN-based validator's allowlist, and add comprehensive integration tests for it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JeroenDeDauw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #484. Still need to actually us this new service as a second layer check.
Results from a back-and-forth session with claude. Reviewed fully by me.
Summary
CypherQueryValidatorinterface in the Application layer withqueryIsAllowed(string $cypher): boolCypherQueryFilter→KeywordCypherQueryValidatorand move toPersistence/Neo4j/ExplainBasedQueryValidator→ExplainCypherQueryValidatorUnwind,NodeCountFromCountStore,RelationshipCountFromCountStore) to the EXPLAIN-based validatorTest plan
KeywordCypherQueryValidatortests pass (83 tests)ExplainCypherQueryValidatorintegration tests pass (22 tests)CypherRawParserFunctionTestpasses (6 tests)🤖 Generated with Claude Code