Refactor SubjectCreator into a single-dialog creation flow #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two-dialog approach (schema picker → editor dialog) created Subjects with dummy IDs and used window.location.reload() after creation. Replace with a single dialog that contains toggle buttons, schema lookup, label input, statement editor, and edit summary. The dialog works with loose data (label, schemaName, statements) instead of constructing a Subject object, and calls subjectStore.createMainSubject directly. Remove Subject.createNew() and the now-unnecessary SubjectCreator.vue component. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by claude based on extensive context I built up yesterday. Reviewed and approved. Locally tested in browser.
Follow up to
Summary
Subject.createNew()which created Subjects with dummy IDs — the dialog now works with loose data and callssubjectStore.createMainSubjectdirectlySubjectCreator.vuecomponent, folding its responsibilities intoSubjectCreatorDialog.vuewindow.location.reload()withmw.notifysuccess/error messages