Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Adds missing test coverage for case variations of the newly blocked admin keywords (GRANT, DENY, REVOKE) and SHOW keyword, following the existing test pattern established for CREATE, SET, etc.

Added test cases:

  • Mixed case variants: GrAnT, DeNy, ReVoKe, ShOw
  • Lowercase variants: deny, revoke (GRANT and SHOW already had lowercase tests)

These tests verify the filter's case-insensitive keyword detection via strtoupper() normalization works correctly for all blocked operations.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 30, 2026 17:22
Co-authored-by: JeroenDeDauw <146040+JeroenDeDauw@users.noreply.github.com>
Co-authored-by: JeroenDeDauw <146040+JeroenDeDauw@users.noreply.github.com>
Co-authored-by: JeroenDeDauw <146040+JeroenDeDauw@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 30, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/JeroenDeDauw/FileFetcher/zipball/d9fadc0486ef690ce7dd9c6d32d6e5f2857bfd80
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/JeroenDeDauw/PsrLogTestDoubles/zipball/201759e3779f0a68088c995a507c938966f2c413
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/d63cee4890a8afaf86a22e51ad4d97c91dd4579b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/composer/installers/zipball/12fb2dfe5e16183de69e784a7b84046c43d97e8e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/composer/pcre/zipball/b2bed4734f0cc156ee1fe9c0da2550420d99a21e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)
  • https://api.github.com/repos/php-http/discovery/zipball/82fe4c73ef3363caed49ff8dd1539ba06044910d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/AAwKKf /usr/bin/composer install (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address feedback on blocking admin and SHOW keywords Add mixed case test coverage for admin and SHOW keywords Jan 30, 2026
Copilot AI requested a review from JeroenDeDauw January 30, 2026 17:25
@JeroenDeDauw JeroenDeDauw reopened this Jan 30, 2026
@JeroenDeDauw JeroenDeDauw marked this pull request as ready for review January 30, 2026 18:08
@JeroenDeDauw JeroenDeDauw merged commit 8bb29c5 into block-admin-cypher-keywords Jan 30, 2026
3 checks passed
@JeroenDeDauw JeroenDeDauw deleted the copilot/sub-pr-485 branch January 30, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants