Fix test failures: register cypher_raw magic word and handle final class in tests

[Copilot]

Fix Test Failures Plan

Issues Identified:

1. Mock Issue: SummarizedResult is a final class and cannot be mocked with PHPUnit

   • Need to create a test stub/wrapper or use actual instances

2. Magic Word Issue: Parser function not registered as magic word

   • Need to create i18n/_Magic.php file
   • Need to register it in extension.json

3. Return Type Issue: Anonymous class stub didn't satisfy the SummarizedResult return type declaration

4. Final Class Stubbing Issue: Even createStub() cannot be used on final classes in PHPUnit

Fix Plan:

• Create magic words file for cypher_raw parser function
• Register magic words file in extension.json
• Fix test mocks to handle final SummarizedResult class
• Fix return type issue by using PHPUnit's createStub for both QueryEngine and SummarizedResult
• Use willReturnCallback with anonymous class to avoid stubbing final class directly

Changes Made:

1. Created i18n/_Magic.php: Defines the cypher_raw magic word for MediaWiki parser
2. Updated extension.json: Registered the magic words file
3. Fixed test approach:
   • Use createMock() for QueryEngine interface
   • Use willReturnCallback() to return an anonymous class that implements toArray()
   • For tests that don't call runReadQuery (empty query, write query), use a simple mock
   • This avoids trying to stub the final SummarizedResult class directly

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Create cypher_raw parser function</issue_title>
<issue_description>For demo purposes. This will not be turned into a more capable function. We might instead add #cypher or similar later in the project.

AC:

• parser function exists {{#cypher_raw: cypher query be here}}
• cypher query is executed
• Write queries are rejected by using CypherQueryFilter
• raw query response is output. Output can be JSON encoded in a codeblock or similar

Backend services for executing Cypher already exist. </issue_description>

<agent_instructions>You won't be able to run the tests since you do not have the MediaWiki environment. Do not try to run them. Just finish what you think is correct and let GitHub Actions run the tests.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes Create cypher_raw parser function #451

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[JeroenDeDauw]

I checked, and seems reasonable to actually check for failed json decode.

[JeroenDeDauw]

@copilot add an usage of this new parser function to DemoData

[Copilot]

@copilot add an usage of this new parser function to DemoData

Added in 51e569a. Created DemoData/Page/Cypher_raw_example.wikitext with three example queries (basic query, filtering, and relations) and linked it from Main_Page under "As a developer" section.

[JeroenDeDauw]

Needs some more work. I call it a day, feel free to take over!

[JeroenDeDauw]

@copilot

There were 3 errors:

1. ProfessionalWiki\NeoWiki\Tests\EntryPoints\CypherRawParserFunctionTest::testValidReadQueryReturnsFormattedResult
   PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method runReadQuery may not return value of type class@anonymous/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:29$79, its declared return type is "Laudis\Neo4j\Databags\SummarizedResult"

/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:72

2. ProfessionalWiki\NeoWiki\Tests\EntryPoints\CypherRawParserFunctionTest::testTrimWhitespaceFromQuery
   PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method runReadQuery may not return value of type class@anonymous/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:29$79, its declared return type is "Laudis\Neo4j\Databags\SummarizedResult"

/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:111

3. ProfessionalWiki\NeoWiki\Tests\EntryPoints\CypherRawParserFunctionTest::testOutputIsHTMLEscaped
   PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method runReadQuery may not return value of type class@anonymous/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:29$79, its declared return type is "Laudis\Neo4j\Databags\SummarizedResult"

/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:131

ERRORS!
Tests: 316, Assertions: 446, Errors: 3, Skipped: 7.

[Copilot]

@copilot

There were 3 errors:
...

Fixed in 55447ce. Replaced the anonymous class stub with PHPUnit's createStub() method which properly handles the return type declaration for SummarizedResult. The stub now creates both a QueryEngine stub and a SummarizedResult stub, allowing test data injection while satisfying type constraints.

[JeroenDeDauw]

@copilot

1. ProfessionalWiki\NeoWiki\Tests\EntryPoints\CypherRawParserFunctionTest::testEmptyQueryReturnsError
   PHPUnit\Framework\MockObject\ClassIsFinalException: Class "Laudis\Neo4j\Databags\SummarizedResult" is declared "final" and cannot be doubled

/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:30
/home/runner/work/NeoWiki/NeoWiki/mediawiki/extensions/NeoWiki/tests/phpunit/EntryPoints/CypherRawParserFunctionTest.php:40

[Copilot]

@copilot

1. ProfessionalWiki\NeoWiki\Tests\EntryPoints\CypherRawParserFunctionTest::testEmptyQueryReturnsError
   ...

Fixed in eff1f32. Changed approach to use willReturnCallback() which returns an anonymous class with toArray() method, avoiding the need to stub the final SummarizedResult class. For tests that don't actually call runReadQuery() (empty query, write query validation), using a simple mock that won't trigger the final class issue.

[JeroenDeDauw]

Replaced by #471 with a clean single commit.