-
Notifications
You must be signed in to change notification settings - Fork 34
Issue Report: CLI Spinner Crash #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Issue Report: CLI Spinner Crash #35
Conversation
Co-authored-by: Jacob Richman <jacob314@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ents (#15025) Co-authored-by: Shnatu <snatu@google.com>
…execution confirmation for non-interactive mode (#14702) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…on format take priority over ones using the old format (#15116)
Co-authored-by: Abhi <abhipatel@google.com>
… (#14606) Co-authored-by: Miguel Solorio <miguelsolorio@google.com>
Co-authored-by: gemini-cli-robot <gemini-cli-robot@google.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Sehoon Shon <sshon@google.com> Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com> Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: Jenna Inouye <jinouye@google.com>
- paths.test.ts: Skip POSIX escapePath tests on Windows, add 8 Windows-specific assertions for double-quoting behavior - cognitiveArchitecture.test.ts: Mock scanSystemSync on Windows with static fixture to avoid slow execSync calls This completes the verification step from tasks_platform_parity.md P0.4 which was previously marked complete but never executed. Fixes Windows CI regression introduced in 32fc11c.
- advisors.test.ts: mock scanSystemSync on Windows - thinkingOrchestrator.test.ts: mock scanSystemSync on Windows - imports.test.ts: mock os.homedir for cross-platform home resolution - shell-utils.test.ts: add 15s timeout to PowerShell AST test - shell-permissions.test.ts: add 15s timeout to PowerShell parser test - confirmation-policy.test.ts: add 15s timeout to async tests
Theme A - System Spec (3 failures): - thinkingOrchestrator.test.ts: add loadSystemSpec mock for executeTask() Theme B - PowerShell AST (2 failures): - shell-utils.test.ts: skip live PowerShell tests on CI - shell-permissions.test.ts: skip live PowerShell tests on CI Theme C - Timeouts (6 failures): - vitest.config.ts: reduce Windows threads (2-4 vs 8-16) to prevent worker pool exhaustion causing 'onTaskUpdate' timeouts
- confirmation-policy.test.ts: 15s → 60s timeout - coreToolScheduler.test.ts: 20s → 60s timeout - clipboardUtils.test.ts: skip clipboard tests on Windows CI - gemini.test.tsx: 30s → 90s timeout - scripts/lint.js: Windows-compatible yamllint installation Root cause: Windows process spawning (PowerShell, cmd.exe) is ~10x slower than Linux. Clipboard operations hang in headless CI.
- Fix browser launch blocking on Linux (spawn + unref) - Fix credential import token reuse (reset lastRefresh) - Fix Redirect URI mismatch (decouple binding to 127.0.0.1 from public localhost) - Add standalone browser launch test script
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🤖 Hi @google-labs-jules[bot], I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @google-labs-jules[bot], but I was unable to process your request. Please see the logs for more details. |
|
Size Change: -1 B (0%) Total Size: 23.1 MB ℹ️ View Unchanged
|
Detailed analysis and proposed fix for the Maximum update depth exceeded error caused by ink-spinner incompatibility.
PR created automatically by Jules for task 1895332716139047333 started by @Prof-Harita