Update $page-subtitle-color to be according WCAG #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$page-subtitle-color now uses $gray-800 to have a good contrast with #F5F7FA and #FFFFFF. In a lot of pages #F5F7FA is the background, so that's why I choose gray-800.
|
@franzejr, please add a |
Tetramputechture
approved these changes
Oct 16, 2019
|
@franzejr, please add a |
pcw0002
approved these changes
Oct 17, 2019
proctoru-bot
assigned franzejr and unassigned onesneakymofo, danielrlatham and wafflewitch
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
lib/hootstrap/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module Hootstrap | |||
| VERSION = '0.12.0' | |||
| VERSION = '0.12.1' | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
|
Code Climate has analyzed commit 8a8cdb7 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
@franzejr If you wouldn't mind, could you freeze the version number? I think that will kick off a new code climate scan and it should be notifying github on scan completion now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$page-subtitle-color now uses $gray-800 to have a good contrast with #F5F7FA and #FFFFFF. In a lot of pages #F5F7FA is the background, so that's why I choose gray-800.
More information, check this website: https://webaim.org/resources/contrastchecker/