Skip to content

FOUR-6854 Replacing the Datepicker! #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 17, 2023
Merged

FOUR-6854 Replacing the Datepicker! #376

merged 19 commits into from
Feb 17, 2023

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented Jan 5, 2023 •
edited
Loading

Issue & Reproduction Steps

Expected behavior:
The new date picker should replicate the same functionality as the old one

Solution

  • Implemented the new date picker
  • Change some functions and cleaned the code

How to Test

  • Run npm run serve and start playing in the background.
    I would recommend linking this package to screen-builder and test it with the functionality there.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Jose Chirivella and others added 17 commits October 31, 2022 17:06
FOUR-6854 Added vue-date-pick
03699fd
FOUR-6854 Replaced the Datepicker component and ran the prettier/lint…
a416274 
…er in this file
@josechirivella
FOUR-6854 Cleaning DatePicker and simplifying some logic
807a1d4
@josechirivella
FOUR-6854 Added functionality to parse and format dates
4a37ec0 
* Added data variables to differentiate datepicker or datetimepicker
* config data variable instead of a computed variable
* Passing format into the library
@josechirivella
FOUR-6854 Removed luxon from our dependencies and setting the current…
4819ffa 
… date using the new Date() from Javascript instead from a library (?)

* Ran prettier into the DemoApp.vue
@josechirivella
FOUR-6854 Added v-once since the helper gets executed only once and i…
e36721c 
…t's only a prop
@josechirivella
FOUR-6854 Removing the $attrs, moved the config object to be a comput…
fdb7bc9 
…ed property,

* Added the $attrs to be new props with their respective Type
* Ran Prettier
@josechirivella
FOUR-6854 Moving attributes to the inputAttribute instead of the cont…
a3f7614 
…ainer

* Datepicker check and format, moved them to be a computed prop
* Added a check to see if the date is valid in parsing
* Forcing the check (according to moment.js docs) on the date format
@josechirivella
FOUR-6854 Added submitDate method which is submitting an emitter
46cdcd6
@josechirivella
FOUR-6854 MaxDate working, testing minDate
11e2817
FOUR-6854 Added functionality for minDate and maxDate
531f680 
* added console.log for Validator
* Commented out startPeriod since it was causing some issues on init
Merge remote-tracking branch 'origin/FOUR-6854' into FOUR-6854
d4505a6 
# Conflicts:
#	src/components/FormDatePicker.vue
FOUR-6854 Added minDate and maxDate functionality
0682023
FOUR-6854 Cleanup the old code for minMaxDate and renamed the func to…
9835c78 
… match logic
FOUR-6854 Added styling for head cells to fix a styling issue with th…
329ec92 
…e Wednesday column
FOUR-6854 Fixed the logic for parsing the input date
822b5de 
* Added displayFormat prop from the library instead of using our function to format the date. Keeping it DRY
* Renamed the function that checks for min-max date to checkMinMaxDateDisabled
* Reworked the logic for mix-max date using the custom func parseDateToDate
* Added jsdocs
Merge branch 'develop' into FOUR-6854
b5e0ad9
@josechirivella josechirivella self-assigned this Jan 5, 2023
@josechirivella josechirivella mentioned this pull request Jan 5, 2023
Merged
9 tasks
caleeli
caleeli reviewed Jan 6, 2023
View reviewed changes
Jose Chirivella added 2 commits January 6, 2023 11:08
FOUR-6854 Removed dead code and console.logs
c3da2c3
FOUR-6854 Added the extent of DatePick library
90ee227 
* Fixed the date prop value to check if the value exist, to parse it. IF not, default to empty string
@caleeli caleeli merged commit 57ff28c into develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodriquelca rodriquelca rodriquelca approved these changes

@caleeli caleeli caleeli approved these changes

Assignees

@josechirivella josechirivella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josechirivella @rodriquelca @caleeli