Skip to content

Fix mustache replacement in SelectLists #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 9, 2021
Merged

Fix mustache replacement in SelectLists #1104

merged 6 commits into from
Nov 9, 2021

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Nov 8, 2021

Fixes: http://tickets.pm4overflow.com/tickets/1205
Requires: ProcessMaker/vue-form-elements#293
This PR includes:

  • Tests to replicate issues with mustache in Select Lists
  • Add missing config option "key" for data sources

@caleeli caleeli changed the base branch from develop to 4.1-develop November 8, 2021 22:33
@marcoAntonioNina marcoAntonioNina merged commit 7938073 into 4.1-develop Nov 9, 2021
@caleeli caleeli mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoAntonioNina marcoAntonioNina marcoAntonioNina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleeli @marcoAntonioNina