Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Screens Data-Loading to Prevent Unnecessary Reloads #8047

Open
wants to merge 1 commit into
base: epic/FOUR-20417
Choose a base branch
from

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Feb 19, 2025

Issue & Reproduction Steps

This PR refines the data-loading pattern for screens to prevent unnecessary reloads when accessing non-listing endpoints. This update ensures the loading state only triggers for the main screens listing endpoint.

Solution

  • Updated the :for data-loading pattern from '/screens/' to'/\/screens\?page/'.
  • Prevents reloading when interacting with non-listing screen-related endpoints.
  • Aligns with pagination query parameter patterns used in other components.
  • Fixes unwanted refreshes when accessing screen-related endpoints.

How to Test

  1. Navigate to Designer > Screens.
  2. Open the VarFinder Panel (Shift + Space).
  3. Go to the "Search" tab.
  4. Ensure the selected asset type is "Screen".
  5. Type anything in the search box.
  6. Verify that the screen listing behind the VarFinder Panel does not reload.

Related Tickets & Packages

FOUR-21890

ci:package-variable-finder:epic/FOUR-20417

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants