Skip to content

FOUR-20834 | Implement Search Option in the VarFinder Panel #7983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Feb 3, 2025

Feature

Ticket: FOUR-20834

This PR enhances the VarFinder Panel by adding the following updates to the functionality of the Search option:

  • Highlights asset names that match user's search filter
  • Adds the icon for the 'Collections' option in the AssetSearch dropdown

How to Test

  1. Go to branch task/FOUR-20834 in package-variable-finder and task/FOUR-20834 in processmaker.
  2. Hit 'Shift' and 'Space' on your keyboard to open the VarFinder Panel.
  3. Select the 'Seach' tab
  4. If you've recently accessed Assets in your environment, the assets should be listed beneath the Search bar
  5. Selecting a different asset type should display the correct asset type in your listing.
  6. You should be able to search for assets by type and name. Matching asset names should be highlighted. Results that do not match your search filter should not display in your listing.

ci:package-variable-finder:task/FOUR-20834

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sanjacornelius sanjacornelius merged commit daa502e into epic/FOUR-20417 Feb 3, 2025
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants