Skip to content

Fix Screen Template Owner Display #7960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Jan 29, 2025

Issue & Reproduction Steps

Resolves an issue where screen templates without an owner displayed 'unclaimed' instead of the default 'ProcessMaker' text.
The screen template listing page was using the default datatable.js transform method which had usePmDefaultLabel set to false. This caused ownerless templates to display as 'unclaimed' instead of the desired default text 'ProcessMaker'.

Solution

  • Added a custom transform method in the screen template listing component
  • Enabled usePmDefaultLabel property to ensure proper owner text formatting

How to Test

  1. Populate the 'Shared Templates' tab:
    php artisan processmaker:sync-screen-templates
    
  2. Navigate to Designer > Screens > Shared Templates tab
  3. Verify the 'Owner' column displays correctly

Expected Results

  • Screen templates without an assigned owner should display 'ProcessMaker' in the Owner column
  • Screen templates with assigned owners should display the owner's name

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ryancooley ryancooley merged commit 014a3bf into release-2025-winter Jan 30, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants