Skip to content

FOUR-21667 | "Edit Template” Link for Screen Templates Does Not Redirect to Edit Page in Screen Builder #7959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Jan 29, 2025

Issue

Ticket: FOUR-21667

When right-clicking on the "Edit Template" link within the Ellipsis Menu for Screen Templates (located on both "My Templates" and "Shared Templates" listing pages), the link incorrectly redirects to the Screens listing page instead of the Screen Builder. This prevents users from editing templates in a new browser tab.

Solution

  • Add screen-template/{id}/edit web route that opens a Screen Template in Screen Builder
  • Add href link to the new route in ellipsisMenuActions.js
  • Remove goToScreenBuilder() method used in navigationMixin.js

How to Test

  1. Go to branch bugfix/FOUR-21667 in processmaker.
  2. Ensure you have Screen Templates in your environment.
  3. Go to Designer → Screens → My Templates.
    • Open the Ellipsis Menu and right-clik on Edit Template to 'Open link in new tab'.
    • Go to the new tab.
    • The new tab should be the Screen Builder page for the selected Screen Template.
  4. Go to Designer → Screens → Shared Templates.
    • Open the Ellipsis Menu and right-clik on Edit Template to 'Open link in new tab'.
    • Go to the new tab.
    • The new tab should be the Screen Builder page for the selected Screen Template.

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-da72e0aa75.engk8s.processmaker.net

@mcraeteisha mcraeteisha requested a review from pmPaulis January 29, 2025 21:38
@pmPaulis
Copy link
Contributor

Approved is working as expected
The edit Screen is open this URL screen-builder/48/edit
Captura de pantalla 2025-01-29 a las 7 58 41 p  m

@ryancooley ryancooley merged commit e7b5f94 into release-2025-winter Jan 30, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants