Skip to content

FOUR-21522 Fix Get variable list without VarFinder package was not implemented #7912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Jan 16, 2025

Fix Get variable list without VarFinder package was not implemented

FixLoadVariablesWithoutVarFinder.mov

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:package-savedsearch:FOUR-21522

@caleeli caleeli requested a review from rodriquelca January 16, 2025 21:37
@caleeli caleeli requested a review from rodriquelca January 17, 2025 18:39
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@caleeli
Copy link
Contributor Author

caleeli commented Jan 17, 2025

The fail in the phpunit tests is related to:

permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.45/containers/json?all=1&filters=%7B%22ancestor%22%3A%7B%22pm4-eks-phpunit%3Alatest%22%3Atrue%7D%7D": dial unix /var/run/docker.sock: connect: permission denied
must specify at least one container source

Caused to the executors microservice, not to the branch changes.

@caleeli caleeli merged commit 0e47e9a into epic/FOUR-20331 Jan 17, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants