-
Notifications
You must be signed in to change notification settings - Fork 227
FOUR-20257 - Grafana #7821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOUR-20257 - Grafana #7821
Conversation
FOUR-20535 Initial Setup (Laravel + Prometheus Integration)
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14796648 | Triggered | Generic Password | 5a10ad0 | metrics/compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
FOUR-20539 Optimize Metrics Collection
Update readme and add namespace config
FOUR-21301 Fix the tests MetricsServiceTest.php and MetricsFacadeTest…
|
@gproly please try removing the commit that has the SEC observation or skip it, so this is no longer an observation. Keep in mind that Engines needs to have this one merged as base. CC: @nolanpro , @ryancooley , @caleeli |
@boliviacoca The issue was fixed but I don't have access to Git Guardian to go in and skip it. It can be safely ignored. |
These changes have been merged into #7913 |
Feature
Establish Grafana APM Pattern/Mechanism
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-20257