Skip to content

FOUR-20257 - Grafana #7821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

FOUR-20257 - Grafana #7821

wants to merge 19 commits into from

Conversation

gproly
Copy link
Contributor

@gproly gproly commented Dec 12, 2024

Feature

Establish Grafana APM Pattern/Mechanism

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-20257

Copy link

gitguardian bot commented Dec 12, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14796648 Triggered Generic Password 5a10ad0 metrics/compose.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gproly gproly requested a review from nolanpro December 18, 2024 14:27
@nolanpro nolanpro changed the title Feature/four 20257 FOUR-20257 - Grafana Jan 14, 2025
@nolanpro nolanpro changed the base branch from release-2024-fall to release-2025-winter January 14, 2025 18:03
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@boliviacoca
Copy link
Contributor

boliviacoca commented Jan 16, 2025

@gproly please try removing the commit that has the SEC observation or skip it, so this is no longer an observation. Keep in mind that Engines needs to have this one merged as base.
Thanks

CC: @nolanpro , @ryancooley , @caleeli

@nolanpro
Copy link
Contributor

@gproly please try removing the commit that has the SEC observation or skip it, so this is no longer an observation. Keep in mind that Engines needs to have this one merged as base. Thanks

CC: @nolanpro , @ryancooley , @caleeli

@boliviacoca The issue was fixed but I don't have access to Git Guardian to go in and skip it. It can be safely ignored.

@nolanpro
Copy link
Contributor

These changes have been merged into #7913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants