Skip to content

FOUR-20467 implement a caching system for settings #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Nov 29, 2024

Issue & Reproduction Steps

Implement a Caching System for Settings

Solution

  • Add the CacheInterface interface
  • Add the SettingCacheManager class
  • Add the SettingCacheFacade facade
  • Register the facade in ProcessMakerServiceProvider.php

Related Tickets & Packages

FOUR-20467

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

*/
public function get(string $key, mixed $default = null): mixed
{
return $this->cacheManager->get($key, $default);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve with error handling example

try {
 return $this->cache->get($key, $default);
    } catch (\Exception $e) {
        // Log the error
        \Log::error("Cache get error: " . $e->getMessage());
        return $default;
    }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error handling was added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, there is a ticket FOUR-20909 to go deeper into it.

@caleeli caleeli merged commit e21e9d8 into epic/FOUR-20326 Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants