Skip to content

FOUR-18935 Ecobank - ERROR 404 ON SECURITY LOGS SWAGGER #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

julceslauhub
Copy link
Contributor

Issue & Reproduction Steps

ApiCollection class is getting all records in order to count the records.

Solution

The count is made using the query object instead the ApiCollection class.

How to Test

  1. Go to API SWAGER: https://api/documentation#/Security%20Logs/getSecurityLogs
  2. Go to Authorize and paste the Bearer Token attached.
  3. Select SecurityLogs
  4. Select GET /security-logs Returns all security logs
  5. Set the parameters per_page to 100 or 10
  6. Or use postman and test the same API

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-18935

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@julceslauhub julceslauhub requested a review from caleeli November 26, 2024 14:39
@marcoAntonioNina marcoAntonioNina self-requested a review November 26, 2024 15:27
@ryancooley ryancooley merged commit 0a399a0 into release-2024-fall Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants