Skip to content

FOUR-20504 enhance test coverage for settings functionality before adding cache #7766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Nov 26, 2024

Issue & Reproduction Steps

Complete the Test coverage of Settings by adding at least the following one:

  • Security Logging: Testing the security logging functionality when changing Settings
  • Format Handling: Testing different data format support (could be saml or email,…)
  • Validation: Fix, update or remove the skipped tests

Solution

  • Add missing tests for core settings
  • Add missing tests for security logs when a setting is updated
  • Add missing tests for setting formats

How to Test

  • Run php artisan test --filter 'SettingLogInOptionsTest|SettingSessionControlTest|SettingAuthTest'

Related Tickets & Packages

FOUR-20504

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@devmiguelangel devmiguelangel self-assigned this Nov 26, 2024
@caleeli caleeli merged commit a3048b5 into epic/FOUR-20326 Nov 27, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants