Skip to content

FOUR-18326 | Implement Layout Application Logic #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Sep 19, 2024

Feature

Tickets:
FOUR-18326
FOUR-18328
FOUR-18329

This PR introduces logic for Applying Layouts and Fields to Screens via the Screen Templates Panel in screen-builder.

When a user chooses to only apply the layout from a template to their screen:

  • The layout is added to the bottom of the screen, enabling the user to arrange the existing information as needed.
  • When the screen has more than one page, the changes will be added to the bottom of the current page.

When a user applies only the fields:

  • The fields are added to the bottom of the screen, providing the user with flexibility to reposition them as required.
  • When the screen has more than one page, the changes will be added to the bottom of the current page.

When applying the complete template:

  • The entire template is placed at the bottom of the screen, allowing the user to make further adjustments as necessary.
  • When the screen has more than one page, the changes will be added to the bottom of the current page.

How to Test

  1. Go to branch task/FOUR-18326 in screen-builder and processmaker.
  2. Ensure you have a Screen Template with Custom CSS, Layouts, and Fields in your environment.
  3. Create a new screen in the Screen Builder.
  4. Select 'Templates'. Select the template card for the Screen Template that has CSS, Layouts, and Fields.
  5. Select 'Layout'.
  • When the page reloads, check that the Layout of the screen meets the following requirements:
    • The layout is added to the bottom of the screen, enabling the user to arrange the existing information as needed.
    • When the screen has more than one page, the changes will be added to the bottom of the current page.
  1. Select 'Templates'. Select the template card for the Screen Template that has CSS, Layouts, and Fields.
  2. Select 'Fields'.
  • When the page reloads, check that the Fields of the screen meet the following requirements:
    • The fields are added to the bottom of the screen, providing the user with flexibility to reposition them as required.
    • When the screen has more than one page, the changes will be added to the bottom of the current page.
  1. Select 'Templates'. Select the template card for the Screen Template that has CSS, Layouts, and Fields.
  2. Select 'CSS', 'Layout', and 'Fields'.
  • When the page reloads, check that the CSS, Layout, and Fields of the screen meet the following requirements:
    • The entire template is placed at the bottom of the screen, allowing the user to make further adjustments as necessary.
    • When the screen has more than one page, the changes will be added to the bottom of the current page.

ci:next
ci:screen-builder:task/FOUR-18326
ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-addbec5329.engk8s.processmaker.net

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@sanjacornelius sanjacornelius merged commit 53207f8 into epic/FOUR-18012 Sep 20, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants