Skip to content

FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Sep 13, 2024

Task

Ticket: FOUR-18315

This PR introduces comprehensive Cypress tests for the Screen Templates Panel in screen-builder and adds template-fetching functionality to screen-builder.

The tests check that:

  • My Templates are displayed when the 'My Templates' button is clicked in the Screen Templates Panel
  • Shared Templares are displayed when the 'Shared Templates' button is clicked in the Screen Templates Panel

This PR also refactors the handling of templates data, and the show/close functionality for the Screen Templates Panel.

How to Test

  1. Go to branch task/FOUR-18315 in screen-builder and processmaker.
  2. Run npx open cypress and npm run dev in your screen-builder terminal.
  3. Run tests for ScreenTemplateSection.spec.js in Cypress.
    • All tests should pass.

ci:next

Screen Builder PR

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@sanjacornelius sanjacornelius merged commit 32b0cbd into epic/FOUR-18012 Sep 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants